Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PowerShell][BUG] Fix issue #18427 - Array context not maintained when converting a parameter to JSON #19262

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

condorcorde
Copy link
Contributor

This PR aims to fix an issue due to PowerShell pipeline behaviour: when an array of a single element is passed into a pipeline the array context is not preserved.

When the result of the pipeline is the generation of the JSON body of an API request, it causes the server side to receive an unexpected type when an array of a single element is passed to the PowerShell client function. See Issue #18427

The fix forces the array context when the parameter corresponding to the variable $LocalVarBodyParameter is an array type.

PSPetstore endpoints that require an array type are not implemented on the server side, so the fix has been tested on the Connectwise PSA API.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. @wing328

@wing328
Copy link
Member

wing328 commented Jul 30, 2024

@wing328
Copy link
Member

wing328 commented Jul 30, 2024

thanks for the PR. let's give it a try

@wing328 wing328 merged commit 16b2811 into OpenAPITools:master Jul 30, 2024
15 checks passed
@condorcorde condorcorde deleted the fix-array-context branch July 31, 2024 13:01
@wing328 wing328 added this to the 7.8.0 milestone Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants