Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][OkHttp-Gson] fix: free form query parameters for okhttp-gson #19226

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

llendi
Copy link
Contributor

@llendi llendi commented Jul 23, 2024

Fix issue #19225

@llendi llendi force-pushed the fix/free-form-okhttp-gson branch from c6170f1 to 0fc8ae9 Compare July 23, 2024 12:38
@wing328
Copy link
Member

wing328 commented Jul 29, 2024

please add a fake endpoint in modules/openapi-generator/src/test/resources/3_0/java/petstore-with-fake-endpoints-models-for-testing-okhttp-gson.yaml.

then please follow step 3 to update the samples so that CI can test the change

@llendi llendi force-pushed the fix/free-form-okhttp-gson branch from 0fc8ae9 to 26c29cb Compare August 5, 2024 19:12
@llendi
Copy link
Contributor Author

llendi commented Aug 5, 2024

Thanks for your reply.

Added the fake endpoint, updated the mustache api and added the samples

@llendi llendi force-pushed the fix/free-form-okhttp-gson branch from 26c29cb to abdf6d4 Compare August 5, 2024 19:47
@llendi llendi force-pushed the fix/free-form-okhttp-gson branch from abdf6d4 to be53a11 Compare August 5, 2024 20:00
@llendi
Copy link
Contributor Author

llendi commented Aug 5, 2024

Updated to make the change minimal. If anything else is missing or needs adjustment, just let me know.

@wing328
Copy link
Member

wing328 commented Aug 14, 2024

cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)

@wing328
Copy link
Member

wing328 commented Aug 15, 2024

thanks for the fix.

let's give it a try

@wing328 wing328 merged commit 38ebf0b into OpenAPITools:master Aug 15, 2024
91 checks passed
@wing328
Copy link
Member

wing328 commented Aug 15, 2024

just merged.

please give it a try with the snapshot version (published in an hour or so) to confirm it's working for you.

thanks again for the PR

@llendi
Copy link
Contributor Author

llendi commented Aug 20, 2024

Works as intended for me. Thank you

@wing328
Copy link
Member

wing328 commented Nov 10, 2024

FYI. Just merged #20076 to suppress the cast warning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants