-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java][OkHttp-Gson] fix: free form query parameters for okhttp-gson #19226
Conversation
c6170f1
to
0fc8ae9
Compare
please add a fake endpoint in then please follow step 3 to update the samples so that CI can test the change |
0fc8ae9
to
26c29cb
Compare
Thanks for your reply. Added the fake endpoint, updated the mustache api and added the samples |
26c29cb
to
abdf6d4
Compare
abdf6d4
to
be53a11
Compare
Updated to make the change minimal. If anything else is missing or needs adjustment, just let me know. |
cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08) |
thanks for the fix. let's give it a try |
just merged. please give it a try with the snapshot version (published in an hour or so) to confirm it's working for you. thanks again for the PR |
Works as intended for me. Thank you |
FYI. Just merged #20076 to suppress the cast warning |
Fix issue #19225