Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(JAVA SPRING RESTCLIENT)Fix missing imports when using withXml for Spring RestClient and fix its README #19146

Merged

Conversation

Nicklas2751
Copy link
Contributor

This PR fixes #19137 by adding the missing imports for "withXML" for the Spring 6 RestClient.
It also fixes the example in the generated README of the RestClient.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
@cachescrubber @welshm @MelleD @atextor @manedev79 @javisst @borsch @banlevente @Zomzog @martin-mfg

…thXml for Spring RestClient and fix its README
@welshm
Copy link
Contributor

welshm commented Jul 12, 2024

This change looks fine to me - however it's not JavaSpring specific, it's just the Java rest-client in general.

@Nicklas2751
Copy link
Contributor Author

This change looks fine to me - however it's not JavaSpring specific, it's just the Java rest-client in general.

@welshm The client I changed is the Spring RestClient which came with Spring 6.1: https://spring.io/blog/2023/07/13/new-in-spring-6-1-restclient and the other Java Clients don‘t have this issue or what do you mean?

@welshm
Copy link
Contributor

welshm commented Jul 12, 2024

This change looks fine to me - however it's not JavaSpring specific, it's just the Java rest-client in general.

@welshm The client I changed is the Spring RestClient which came with Spring 6.1: https://spring.io/blog/2023/07/13/new-in-spring-6-1-restclient and the other Java Clients don‘t have this issue or what do you mean?

Sorry my mistake - I was looking at the file paths - it just says rest client and makes no mention of Spring.

Change looks good to me

@wing328 wing328 merged commit 045f4b6 into OpenAPITools:master Jul 17, 2024
74 checks passed
@wing328 wing328 changed the title fix (JAVA SPRING RESTCLIENT) 19137: Fix missing imports when using withXml for Spring RestClient and fix its README (JAVA SPRING RESTCLIENT)Fix missing imports when using withXml for Spring RestClient and fix its README Jul 17, 2024
@wing328 wing328 added this to the 7.8.0 milestone Jul 17, 2024
@Nicklas2751 Nicklas2751 deleted the feature/fix-restclient-xml-imports branch October 10, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][Java][Client][RestClient] Missing imports when using withXml
3 participants