Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASPNETCORE] Fix having two "?" when not required and nullable = true #19062

Merged
merged 3 commits into from
Jul 6, 2024

Conversation

JFCote
Copy link
Member

@JFCote JFCote commented Jul 3, 2024

Fix having two "?" when not required and nullable = true

This will close all these issues:

#18005
#18081

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@mandrean (2017/08) @shibayan (2020/02) @Blackclaws (2021/03) @lucamazzanti (2021/05) @iBicha (2023/07)

@JFCote
Copy link
Member Author

JFCote commented Jul 3, 2024

@wing328 I am not able to fix the latest error in the CI because I'm under windows and I don't have the same line ending. (CRLF)

@wing328
Copy link
Member

wing328 commented Jul 6, 2024

pushed 079633b to update the samples. let's see how that goes

@wing328 wing328 merged commit 0b1b3f5 into master Jul 6, 2024
29 checks passed
@wing328 wing328 deleted the bugfixes/18005 branch July 6, 2024 13:56
@wing328 wing328 added this to the 7.8.0 milestone Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants