Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid UnsupportedEncodingException by design, replacing magic string "UTF-8" with StandardCharsets.UTF_8 #18851

Conversation

Philzen
Copy link
Contributor

@Philzen Philzen commented Jun 4, 2024

This makes for much more concise code 😃

Unfortunately that API is not available in Java 8, so most templates will have to stay as they are.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@Philzen Philzen force-pushed the change/avoid-UnsupportedEncodingException-by-design branch from c06a605 to 03205a0 Compare June 4, 2024 13:48
@Philzen Philzen changed the title Avoid UnsupportedEncodingException by design by replacing magic string "UTF-8" / "utf8" with StandardCharsets.UTF_8 Avoid UnsupportedEncodingException by design by replacing magic string "UTF-8" with StandardCharsets.UTF_8 Jun 4, 2024
@Philzen Philzen changed the title Avoid UnsupportedEncodingException by design by replacing magic string "UTF-8" with StandardCharsets.UTF_8 Avoid UnsupportedEncodingException by design, replacing magic string "UTF-8" with StandardCharsets.UTF_8 Jun 4, 2024
@Philzen Philzen marked this pull request as ready for review June 4, 2024 14:14
@Philzen Philzen requested review from borsch and wing328 June 5, 2024 07:27
@Philzen Philzen force-pushed the change/avoid-UnsupportedEncodingException-by-design branch from 03205a0 to c18125d Compare June 6, 2024 14:43
@Philzen
Copy link
Contributor Author

Philzen commented Jun 7, 2024

@borsch @wing328 Anybody up for a quick review?

@wing328
Copy link
Member

wing328 commented Jun 7, 2024

let me review over the weekend.

thanks again for the PR

have a nice weekend

@wing328
Copy link
Member

wing328 commented Jun 8, 2024

lgtm. let's give it a try

@wing328 wing328 merged commit 5adf1ff into OpenAPITools:master Jun 8, 2024
101 checks passed
@wing328 wing328 added Client: Java Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. labels Jun 8, 2024
@wing328 wing328 added this to the 7.7.0 milestone Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client: Java Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants