Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service api fix #18767

Merged
merged 3 commits into from
May 26, 2024
Merged

Service api fix #18767

merged 3 commits into from
May 26, 2024

Conversation

aaronp
Copy link
Contributor

@aaronp aaronp commented May 26, 2024

This Scala cask change makes the service traits available to Both JVM and JS platforms.

It does this by moving the Service interfaces into the shared source directory

PR checklist

  • [x ] Read the contribution guidelines.
  • [ x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [ x] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

aaronp added 3 commits May 25, 2024 22:31
Both JVM and JS platforms.

It does this by moving the api interfaces into the cross-platform
Shared sources
aaronp added a commit to aaronp/onboarding-backend that referenced this pull request May 26, 2024
https://github.com/aaronp/docstore

Note: compiling locally requires running

make generateModels

And those models are dependent on putting the API services in the shared directory,
which is this PR:
OpenAPITools/openapi-generator#18767
@wing328
Copy link
Member

wing328 commented May 26, 2024

@wing328 wing328 merged commit e696448 into OpenAPITools:master May 26, 2024
25 of 26 checks passed
@wing328 wing328 added this to the 7.7.0 milestone May 26, 2024
@aaronp aaronp deleted the serviceApiFix branch October 22, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants