Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][native] Fix: useEnumCaseInsensitive option fixed in Java Native Model Enum #18762

Merged

Conversation

oguzdemirbasci
Copy link
Contributor

@oguzdemirbasci oguzdemirbasci commented May 25, 2024

useEnumCaseInsensitive option does not work in Java Enum Classes for native library. It is implemented implemented in the default template but not in the native template. This PR copies the conditional equalsIgnoreCase call from default template to native.

Seems like this change was forgotten in this PR: #15273

More details are shared in this issue: #18761

Java Committee Members:
@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @martin-mfg

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Jun 17, 2024

tested locally to confirm the fix

--- a/src/main/java/org/openapitools/client/model/EnumTest.java
+++ b/src/main/java/org/openapitools/client/model/EnumTest.java
@@ -55,7 +55,7 @@ public enum EnumTest {
   @JsonCreator
   public static EnumTest fromValue(String value) {
     for (EnumTest b : EnumTest.values()) {
-      if (b.value.equals(value)) {
+      if (b.value.equalsIgnoreCase(value)) {
         return b;
       }
     }

thanks for the PR

@wing328 wing328 merged commit 18b4bcb into OpenAPITools:master Jun 17, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants