Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JAVA] Fix optional collection initialized with object [fix: #18735] #18738

Conversation

mosesonline
Copy link
Contributor

Since 7.5.0 optional field in collections where initialized with an Object (i.e. new ArrayList<>()) but before they where initialized with null. This PR fixes this by using the required-Property to skip returning null and returning a default-Value. (#18735)

I've also added a test for it.

technical committee member: @martin-mfg

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

check required collections are not null
update samples and tests
@mosesonline mosesonline force-pushed the required-collection-issue-fix branch from 3b1a057 to e8c9139 Compare June 17, 2024 19:20
@mosesonline mosesonline force-pushed the required-collection-issue-fix branch from 540b5a4 to 40f8dee Compare June 22, 2024 22:55
@mosesonline
Copy link
Contributor Author

The current behavior is compliant with Open API specification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant