-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise how to obtain the example value #183
Merged
jmini
merged 7 commits into
OpenAPITools:master
from
ackintosh:revise-how-to-obtain-example-value
Jun 28, 2018
Merged
Revise how to obtain the example value #183
jmini
merged 7 commits into
OpenAPITools:master
from
ackintosh:revise-how-to-obtain-example-value
Jun 28, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ackintosh
force-pushed
the
revise-how-to-obtain-example-value
branch
from
May 31, 2018 01:07
807a549
to
8a1f3b2
Compare
ackintosh
force-pushed
the
revise-how-to-obtain-example-value
branch
from
May 31, 2018 01:22
8a1f3b2
to
cbac157
Compare
@ackintosh I've added the WIP label. |
…ain-example-value
ackintosh
changed the title
[WIP] Revise how to obtain the example value
Revise how to obtain the example value
Jun 23, 2018
@OpenAPITools/generator-core-team |
jmini
approved these changes
Jun 28, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, can you please merge master
into your branch or rebase your commit on top of master
Thanks for your reivew! Merged master into this branch. 👷 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.master
.Description of the PR
This is the first fix for
example
.