Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise how to obtain the example value #183

Merged

Conversation

ackintosh
Copy link
Contributor

@ackintosh ackintosh commented May 30, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

This is the first fix for example.

@ackintosh ackintosh force-pushed the revise-how-to-obtain-example-value branch from 807a549 to 8a1f3b2 Compare May 31, 2018 01:07
@ackintosh ackintosh force-pushed the revise-how-to-obtain-example-value branch from 8a1f3b2 to cbac157 Compare May 31, 2018 01:22
@jimschubert jimschubert added the WIP Work in Progress label Jun 10, 2018
@jimschubert
Copy link
Member

@ackintosh I've added the WIP label.

@ackintosh ackintosh changed the title [WIP] Revise how to obtain the example value Revise how to obtain the example value Jun 23, 2018
@ackintosh ackintosh removed the WIP Work in Progress label Jun 23, 2018
@ackintosh
Copy link
Contributor Author

@OpenAPITools/generator-core-team

Copy link
Member

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, can you please merge master into your branch or rebase your commit on top of master

@ackintosh
Copy link
Contributor Author

Thanks for your reivew! Merged master into this branch. 👷

@ackintosh ackintosh added this to the 3.1.0 milestone Jun 28, 2018
@jmini jmini merged commit 0c11718 into OpenAPITools:master Jun 28, 2018
@ackintosh ackintosh deleted the revise-how-to-obtain-example-value branch June 28, 2018 21:48
@jmini jmini mentioned this pull request Jun 29, 2018
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants