Autoset constants (Required fields having single valid enum value) C# Implementation of #16547 #17954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashant-pant
force-pushed
the
autoset-constants
branch
from
88f5ec1 to
f44ffee
Compare
|
thanks for the PR. can you please also update the following API template files as well?
|
prashant-pant
force-pushed
the
autoset-constants
branch
2 times, most recently
from
4c37865 to
4fbafb1
Compare
Done in 4fbafb1 |
|
cc |
wing328
reviewed
Mar 1, 2024
modules/openapi-generator/src/main/resources/csharp/libraries/generichost/api.mustache
Show resolved
Hide resolved
prashant-pant
force-pushed
the
autoset-constants
branch
2 times, most recently
from
9468c6e to
f7acb0b
Compare
…singleton enums values.
prashant-pant
force-pushed
the
autoset-constants
branch
from
f7acb0b to
e34e074
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code Changes
Partial implementation of #16547
If
autosetConstantsis set to True, the generated code by C# generator will hardcode values for any Header / Query Param which is marked as required and can only have a single valid enum value.The single valued required enum i.e. The constant param will be removed from the method signature.
Testing
A test case has been added that asserts that if
autosetConstantsis set to true then the constant key/value pair is being set in the generated code.I've run
./bin/generate-samples.shand there is no change in existing code generation if the newautosetConstantsproperty is not set, Therefore there should not be any risk in getting this change merged.