-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dart] Make dependency on intl package less strict #17862
Conversation
@ahmednfwela @sbu-WBT Thanks for the quick review cycle! Can you also merge the PR? |
@wiesnery |
@aviadkam As there don't seem to be any documented API changes we could go from |
For Another thought - If |
As far as I understood the |
I agree. If you could do the PR, I would appreciate it. It will be my first PR on the project, and it always takes more time for a freshman. If you are not available, then I will do it. Thank you |
you can finde the PR for http, collection and meta here #18952 |
Thank you very very much!! |
The hard reuirement of
intl: '^0.18.0'
limits current and future update behavior.It is recommended by the flutter team to depend on
intl: any
instead.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)@jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12) @ahmednfwela (2021/08)