Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate API files as interfaces for go-gin server #17784

Merged
merged 7 commits into from
Feb 20, 2024

Conversation

mfatihercik
Copy link
Contributor

Details are in here.

No Breaking Changes

FYI
@antihax @grokify @kemokemo @jirikuncar @ph4r5h4d @lwj5

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@mfatihercik
Copy link
Contributor Author

@antihax @grokify @kemokemo @jirikuncar @ph4r5h4d @lwj5

is there a blocker to merge this?

@wing328
Copy link
Member

wing328 commented Feb 15, 2024

can you please update .github/workflows/samples-go.yaml with the new sample folder so that CI can test it moving forward?

@wing328
Copy link
Member

wing328 commented Feb 15, 2024

please also PM me via Slack when you've time. thank you

@wing328
Copy link
Member

wing328 commented Feb 20, 2024

let's give it a try. thanks for the PR

@wing328 wing328 merged commit 48565ae into OpenAPITools:master Feb 20, 2024
16 checks passed
kota65535 pushed a commit to kota65535/openapi-generator that referenced this pull request Feb 23, 2024
* add feature to generate only interface files

* generate sample

* add workflow file foe go gin service

* add workflow file foe go gin service

* add workflow file foe go gin service

* update samples
oscarr-reyes pushed a commit to oscarr-reyes/openapi-generator that referenced this pull request Feb 25, 2024
* add feature to generate only interface files

* generate sample

* add workflow file foe go gin service

* add workflow file foe go gin service

* add workflow file foe go gin service

* update samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants