Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][apache-httpclient][feign][okhttp-gson] Enable access token refresh #17086

Merged
merged 3 commits into from
Nov 18, 2023

Conversation

kota65535
Copy link
Contributor

@kota65535 kota65535 commented Nov 15, 2023

Partially fix: #16059

This PR partially fixes the issue for Java clients of apache-httpclient, feign and okhttp-gson.
Here I choose these libraries because they have echo-api samples that enable us to write tests for the functionality of the generated codes. Please look into AuthApiTest.java in the sample of each library.

To Java technical committee: @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@kota65535 kota65535 marked this pull request as ready for review November 15, 2023 17:48
@wing328 wing328 modified the milestones: 8.0.0, 7.2.0 Nov 18, 2023
@wing328
Copy link
Member

wing328 commented Nov 18, 2023

lgtm.

(I assume these are not breaking changes, please correct me if I'm wrong)

@kota65535
Copy link
Contributor Author

Yes, I believe there is no breaking change as I confirmed in each test.

@wing328 wing328 merged commit 4bedeef into OpenAPITools:master Nov 18, 2023
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ][Java] Support refreshing access tokens
2 participants