Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling of API response in 3.1 spec #16986

Merged
merged 3 commits into from
Nov 5, 2023
Merged

Better handling of API response in 3.1 spec #16986

merged 3 commits into from
Nov 5, 2023

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Nov 5, 2023 •
edited
Loading

to fix #16965

FYI @OpenAPITools/generator-core-team

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh ./bin/configs/*.yaml
./bin/utils/export_docs_generators.sh
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
    Do NOT purge/delete any folders/files when regenerating the samples
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 added this to the 7.1.0 milestone Nov 5, 2023
@wing328 wing328 marked this pull request as ready for review November 5, 2023 06:37
@wing328 wing328 requested a review from jimschubert as a code owner November 5, 2023 06:37
@wing328 wing328 merged commit de85999 into master Nov 5, 2023
100 checks passed
@wing328 wing328 deleted the response-ref branch November 5, 2023 07:24
@wing328 wing328 mentioned this pull request Nov 5, 2023
Merged
5 tasks
@wing328
Copy link
Member Author

wing328 commented Nov 5, 2023

Filed #16988 with minor refactoring

@wing328 wing328 mentioned this pull request Nov 5, 2023
Closed
6 tasks
wing328
wing328 commented Nov 7, 2023
View reviewed changes
modules/openapi-generator/src/main/java/org/openapitools/codegen/utils/ModelUtils.java
public static Schema getSchemaFromResponse(ApiResponse response) {
return getSchemaFromContent(response.getContent());
public static Schema getSchemaFromResponse(OpenAPI openAPI, ApiResponse response) {
return getSchemaFromContent(getReferencedApiResponse(openAPI, response).getContent());
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed #17003 with better null check

@wing328 wing328 mentioned this pull request Nov 8, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimschubert jimschubert Awaiting requested review from jimschubert

Assignees
No one assigned
Labels
Enhancement: Feature Feature: Generator Feature: OAS 3.1.0 spec support
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.

[BUG] Responses using references are not properly expanded
1 participant
@wing328