-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[csharp][generichost] Implement not required nullable properties #16810
[csharp][generichost] Implement not required nullable properties #16810
Conversation
as discussed if the users prefer the old(existing) order of the parameters, we will create |
appveyor tests passed via https://ci.appveyor.com/project/WilliamCheng/openapi-generator/builds/48448381 |
Wow @devhl-labs thank you so much for this so valuable and important feature! I see it really was a lot of work! Very useful and much appreciated! Has this been released already to npm? |
Probably, but i am not familiar with that. |
…nAPITools#16810) * init * fixed read and write * completed changes using latest-nrt sample * fixed all samples * add null check on write, change on exception * resolved conflicts * build samples * added backing property for not required properties * more not required and nullable hanlding improvements * revert sample updates for a merge master * revert sample updates for a merge master * sample build is working, need to remove warnings * fixed warnings in .net 7 with nrt * fixed manual tests * fixed all samples * fix npe * removed debugging lines * revert changes to unused file * removed unused lambdas * fix a serialization bug * make option a hidden property * updated documentation * improved parameter ordering
Fixes #16520
Breaking change without fallback due to changing the order of model properties. Not required, nullable, and any values with a default now at the end of the model's signature since the user does not have to provide anything for those properties.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)