Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Fix unnamed dicts with additional properties #16779

Merged

Conversation

robertschweizer
Copy link
Contributor

Closes #16630

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328

@robertschweizer robertschweizer changed the title Fix dict of list of strings [python] Fix dict of list of strings Oct 10, 2023
@robertschweizer robertschweizer changed the title [python] Fix dict of list of strings [python] Fix unnamed dicts with additional properties Oct 10, 2023
@wing328 wing328 added this to the 7.1.0 milestone Oct 11, 2023
@wing328
Copy link
Member

wing328 commented Oct 11, 2023

thanks for the fix and adding the tests

@wing328 wing328 merged commit f180aa0 into OpenAPITools:master Oct 11, 2023
31 checks passed
robertschweizer added a commit to robertschweizer/openapi-generator that referenced this pull request Oct 11, 2023
wing328 pushed a commit that referenced this pull request Oct 11, 2023
AlanCitrix pushed a commit to AlanCitrix/openapi-generator that referenced this pull request Oct 26, 2023
…6779)

* test: Add two extra models for testing

* Fix unnamed dicts with additional properties

Closes OpenAPITools#16630
AlanCitrix pushed a commit to AlanCitrix/openapi-generator that referenced this pull request Oct 26, 2023
fa0311 added a commit to fa0311/openapi-generator that referenced this pull request Mar 15, 2024
wing328 pushed a commit that referenced this pull request Mar 16, 2024
…8112)

* [python-pydantic-v1] pick #16779

* [python] update sample
zapodot pushed a commit to zapodot/openapi-generator that referenced this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][python] Errors in to_dict() with additionalProperties of type array
2 participants