[Java][client] Fix feign classcastexception when getting headers #16745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Collection<String> and not List<String>) Delete unused classes
Refactor to avoid creating the headers map when ApiResponse is not used
robertdanci
commented
Oct 6, 2023
|
|
||
| private int status; | ||
|
|
||
| public HttpResponse(Map<String, Collection<String>> headers, T body, int status) { |
There was a problem hiding this comment.
No longer used, replaced by ApiResponse
robertdanci
commented
Oct 6, 2023
|
|
||
| import org.openapitools.client.model.HttpResponse; | ||
|
|
||
| public class JacksonResponseDecoder extends JacksonDecoder { |
There was a problem hiding this comment.
No longer used, replaced by ApiResponseDecoder
robertdanci
commented
Oct 6, 2023
| @@ -49,8 +49,6 @@ nb-configuration.xml | |||
| /target | |||
| /generated-files | |||
| test-output/ | |||
| nbactions.xml | |||
There was a problem hiding this comment.
I removed a bunch of duplicates
robertdanci
changed the title
|
thanks for the PR with the detailed explanation. lgtm |
AlanCitrix
pushed a commit
to AlanCitrix/openapi-generator
that referenced
this pull request
Oct 26, 2023
…nAPITools#16745) * Avoid ClassCastException when getting headers (the header values are Collection<String> and not List<String>) Delete unused classes * Remove feign10x * Add unit test Refactor to avoid creating the headers map when ApiResponse is not used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This affects the feign apis that return ApiResponse which contains extra request info such as headers and status.
The current implemenation holds the headers in a Map<String, List> but feign uses Map<String, Collection>. Since the headers are copied as they are in ApiResponseDecoder.java when one tries to get them one gets a ClassCastException. That is because Feign wrapps the headers in an unmodifiableCollection, see here. Regardless of the underlying implementation the correct type is Map<String, Collection> but since the ApiResponseDecoder uses raw types, this type missmatch is hidden. This has also been addressed. See here Feign's response for context.
I also deleted feign10x sample folder since it seems it not in use anymore. The generator only supports Feign 10.x+ so there no need for something version specific.
@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @martin-mfg
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)