Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update java examples with correct dependencies needed for OpenApi >= 5.4 #16719

Closed

Conversation

Philzen
Copy link
Contributor

@Philzen Philzen commented Oct 3, 2023

Fixes #16701

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

In Version 5.4.0 OpenApi-Generator has replaced the legacy library
which provided the `io.swagger.annotations.*` namespace (hosted at
https://mvnrepository.com/artifact/io.swagger/swagger-annotations)
with the updated project that provides `io.swagger.v3.oas.annotations.*`.

Hence, if you want to use OpenApi-Generator >= 5.4.0 you need this
package https://mvnrepository.com/artifact/io.swagger.core.v3/swagger-annotations
which is now reflected in these example files.
@Philzen Philzen requested a review from jimschubert as a code owner October 3, 2023 21:37
@Philzen Philzen changed the title 16701 java examples dont compile Update java examples with correct dependencies needed for OpenApi >= 5.4 Oct 3, 2023
@wing328 wing328 mentioned this pull request Oct 4, 2023
5 tasks
@wing328
Copy link
Member

wing328 commented Oct 4, 2023

I've fixed the spring maven plugin tests with #16720 instead.

closing this one.

@wing328 wing328 closed this Oct 4, 2023
@Philzen
Copy link
Contributor Author

Philzen commented Oct 6, 2023

@wing328 just a sidenote: would have preferred you to merge this one first (so i get the credits in the commit history) or told me right away in #16701 (comment) that you were going to overhaul this (so i could have saved myself the time to update this PR for nothing).

@wing328
Copy link
Member

wing328 commented Oct 7, 2023

your commits already included in my PR: https://github.com/OpenAPITools/openapi-generator/pull/16720/commits, so you do get the credits. You can run git log in the latest master to verify.

have a nice weekend.

@Philzen
Copy link
Contributor Author

Philzen commented Oct 8, 2023

your commits already included in my PR: https://github.com/OpenAPITools/openapi-generator/pull/16720/commits, so you do get the credits. You can run git log in the latest master to verify.

have a nice weekend.

@wing328 Sincerest apologies for what could have been considered a slight rant from my side. I missed the fact you kindly built upon my earlier commits, thanks a lot. 🙏

Keep up the great work, wishing you an awesome start into the week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Java examples don't compile
2 participants