Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add prefix and suffix to discriminator #16684

Conversation

MatthiasGabriel
Copy link
Contributor

@MatthiasGabriel MatthiasGabriel commented Sep 28, 2023

Use the existing toModelName method to normalize the discriminator

I stumbled upon the issue #16391 when I was trying to use an Enum as a discriminator which was added in #13846

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Use the existing toModelName method to normalize the discriminator
@MatthiasGabriel
Copy link
Contributor Author

@welshm @cachescrubber @ddoming73 @wing328 any feedback to this mini MR?
Sorry to tag you directly, but you were involved in the original MR...

@wing328
Copy link
Member

wing328 commented Oct 3, 2023

cc @OpenAPITools/generator-core-team

@wing328
Copy link
Member

wing328 commented Oct 3, 2023

lgtm. let's give it a try.

@wing328 wing328 merged commit 4075a52 into OpenAPITools:master Oct 3, 2023
11 checks passed
AlanCitrix pushed a commit to AlanCitrix/openapi-generator that referenced this pull request Oct 26, 2023
Use the existing toModelName method to normalize the discriminator

Co-authored-by: Matthias Gabriel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants