Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[csharp] Version bump #16657

Merged
merged 1 commit into from
Oct 11, 2023
Merged

[csharp] Version bump #16657

merged 1 commit into from
Oct 11, 2023

Conversation

devhl-labs
Copy link
Contributor

@devhl-labs devhl-labs commented Sep 24, 2023

See this post https://github.com/GregFinzer/Compare-Net-Objects/issues/282#issuecomment-1697644613 for explanation of the ClientUtils change.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@devhl-labs
Copy link
Contributor Author

The samples were built. There is a bug in the echo sample. The task needs to be awaited.
image

@wing328
Copy link
Member

wing328 commented Oct 11, 2023

@wing328 wing328 merged commit 2cfce7c into OpenAPITools:master Oct 11, 2023
@wing328
Copy link
Member

wing328 commented Oct 12, 2023

The samples were built. There is a bug in the echo sample. The task needs to be awaited.

Filed #16804 to workaround the issue

AlanCitrix pushed a commit to AlanCitrix/openapi-generator that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants