Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java][jaxrs-jersey][java-msf4j] remove jersey 1 #16646

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

martin-mfg
Copy link
Contributor

@martin-mfg martin-mfg commented Sep 22, 2023

closes #13783

I assume jersey 1 should still be removed, even though the original target version 7.0 is released already. So I think this should go into the 8.x branch, but that doesn't exist yet.

Also, I removed jersey1 everywhere, not just in the java client generator.

After removing jersey1, in some places jersey2 is the only left option. E.g. for generator "jaxrs-jersey", the "library" option can only be "jersey2". For now I anyway left the "library" option in place, because we might want to add jersey 3 there. If you want me to remove the "library" option alltogether, please let me know.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)

@wing328
Copy link
Member

wing328 commented Sep 26, 2023

For now I anyway left the "library" option in place, because we might want to add jersey 3 there. If you want me to remove the "library" option alltogether, please let me know.

we can keep it for the time being

@wing328 wing328 merged commit 1cff462 into OpenAPITools:master Sep 26, 2023
@wing328 wing328 added this to the 7.1.0 milestone Sep 26, 2023
AlanCitrix pushed a commit to AlanCitrix/openapi-generator that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Announcement] jersey1 library in Java client generator will be decommissioned
2 participants