Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][Spring] Fix RequestPart/RequestParam handling on multipart request in reactive stack #16535

Merged
merged 18 commits into from
Oct 1, 2023
Merged

[Java][Spring] Fix RequestPart/RequestParam handling on multipart request in reactive stack #16535

merged 18 commits into from
Oct 1, 2023

Conversation

jorgerod
Copy link
Contributor

@jorgerod jorgerod commented Sep 8, 2023

This error is perfectly explained here. In reactive you should not use @RequestParam instead of @RequestPart.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (7.0.1 - patch release), 7.1.x (minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08)

@welshm
Copy link
Contributor

welshm commented Sep 11, 2023

I think @borsch has more context given the other PRs listed here, but this seems correct to me based on the description of the error - thanks for looking into this!

@jorgerod
Copy link
Contributor Author

Hi @borsch,

Do you see the PR well?

CC/ @welshm

@wing328
Copy link
Member

wing328 commented Oct 1, 2023

let's give it a try. thanks for the PR.

@wing328 wing328 merged commit ee5d9f6 into OpenAPITools:master Oct 1, 2023
@wing328 wing328 added this to the 7.1.0 milestone Oct 1, 2023
AlanCitrix pushed a commit to AlanCitrix/openapi-generator that referenced this pull request Oct 26, 2023
…uest in reactive stack (OpenAPITools#16535)

* Fix requestpart in reactive

* Update samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants