-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect @InputFile on inputSpecRootDirectory argument #16420
Conversation
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
Thanks for the PR. Can you please add tests to cover the issue moving forward? |
Added test to cover the scenario. Turns out it was a good thing to do since the solution didn't work yet. Fixed several more issues to get it to work. I think I also fixed my email in my git config, let me know if it's still an issue. |
Any updates on that PR? Would be great to have it in |
Just merged. Please help test the SNAPSHOT version (which will be published shortly in 30 mins) |
Hi @wing328 , can you please let me know in which plugin version I can expect this fix ? I could see that it has been merged long before but any version is not published after. |
I'm also interested in knowing when this will be released |
It doesn't seem like you can properly consume the SNAPSHOT versions properly with gradle (probably only with the old hacky way of specifying it, which I don't know if it's still supported at all and doesn't work with version catalogs), since the gradle plugin isn't published at it's plugin ID Edit: Yes, the old way still works, but it definitely comes with some issues... |
To fix #16419
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(7.0.1 - patch release),7.1.x
(minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)