Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect @InputFile on inputSpecRootDirectory argument #16420

Merged
merged 4 commits into from
Sep 21, 2023

Conversation

Luckl
Copy link
Contributor

@Luckl Luckl commented Aug 27, 2023

To fix #16419

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (7.0.1 - patch release), 7.1.x (minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@Luckl Luckl requested a review from jimschubert as a code owner August 27, 2023 18:12
@wing328
Copy link
Member

wing328 commented Aug 28, 2023

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328
Copy link
Member

wing328 commented Aug 28, 2023

Thanks for the PR. Can you please add tests to cover the issue moving forward?

@Luckl
Copy link
Contributor Author

Luckl commented Aug 28, 2023

Thanks for the PR. Can you please add tests to cover the issue moving forward?

Added test to cover the scenario. Turns out it was a good thing to do since the solution didn't work yet. Fixed several more issues to get it to work.

I think I also fixed my email in my git config, let me know if it's still an issue.

@wing328 wing328 modified the milestones: 7.0.1, 7.1.0 Sep 19, 2023
@romanutti
Copy link

Any updates on that PR? Would be great to have it in 7.1.0 🚀

@wing328 wing328 changed the title fix #16419 fix incorrect @InputFile on inputSpecRootDirectory argument Fix incorrect @InputFile on inputSpecRootDirectory argument Sep 21, 2023
@wing328 wing328 merged commit 29033bf into OpenAPITools:master Sep 21, 2023
@wing328
Copy link
Member

wing328 commented Sep 21, 2023

Just merged. Please help test the SNAPSHOT version (which will be published shortly in 30 mins)

@monisharajan
Copy link

Hi @wing328 , can you please let me know in which plugin version I can expect this fix ? I could see that it has been merged long before but any version is not published after.

@benmaes
Copy link

benmaes commented Oct 24, 2023

Hi @wing328 , can you please let me know in which plugin version I can expect this fix ? I could see that it has been merged long before but any version is not published after.

I'm also interested in knowing when this will be released

@cromefire
Copy link

cromefire commented Nov 4, 2023

Just merged. Please help test the SNAPSHOT version (which will be published shortly in 30 mins)

It doesn't seem like you can properly consume the SNAPSHOT versions properly with gradle (probably only with the old hacky way of specifying it, which I don't know if it's still supported at all and doesn't work with version catalogs), since the gradle plugin isn't published at it's plugin ID org.openapi.generator:org.openapi.generator.gradle.plugin.

Edit: Yes, the old way still works, but it definitely comes with some issues...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][GRADLE] Gradle plugin does not properly support inputSpecRootDirectory
6 participants