Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of Inline schema #15682

Merged
merged 25 commits into from
Jun 11, 2023
Merged

Better handling of Inline schema #15682

merged 25 commits into from
Jun 11, 2023

Conversation

wing328
Copy link
Member

@wing328 wing328 commented May 30, 2023

Skip allOf inline subschema created as $ref

To fallback, please use the --inline-schema-name-defaults option as follows

e.g. --inline-schema-name-defaults REFACTOR_ALLOF_INLINE_SCHEMAS=true

(csharp client generators has this fallback enabled by default)

cc @OpenAPITools/generator-core-team

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 mentioned this pull request May 30, 2023
5 tasks
@wing328 wing328 added Enhancement: General Inline Schema Handling Schema contains a complex schema in items/additionalProperties/allOf/oneOf/anyOf labels Jun 3, 2023
@wing328 wing328 added this to the 7.0.0 milestone Jun 9, 2023
@wing328 wing328 marked this pull request as ready for review June 9, 2023 12:37
@wing328 wing328 merged commit 6788f43 into master Jun 11, 2023
@wing328 wing328 deleted the skip-allof-inline-creation branch June 11, 2023 07:36
makru86 pushed a commit to makru86/openapi-generator that referenced this pull request Jun 12, 2023
* skip allOf inline subschema created as $ref

* add option for fallback

* add back atleastonemodel

* add log

* update java, kotlin, js samples

* update tests

* fix native client test

* fix java client errors by regenerating test files

* clean up python

* clean up powershell

* clean up php

* clean up ruby

* update erlang, elixir

* update dart samples

* update ts samples

* update r, go samples

* update perl

* update swift

* add back files

* add back files

* remove outdated test files

* fix test
fmoraespadtec pushed a commit to padteclab/openapi-generator that referenced this pull request Jun 26, 2023
* skip allOf inline subschema created as $ref

* add option for fallback

* add back atleastonemodel

* add log

* update java, kotlin, js samples

* update tests

* fix native client test

* fix java client errors by regenerating test files

* clean up python

* clean up powershell

* clean up php

* clean up ruby

* update erlang, elixir

* update dart samples

* update ts samples

* update r, go samples

* update perl

* update swift

* add back files

* add back files

* remove outdated test files

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change (with fallback) Enhancement: General Inline Schema Handling Schema contains a complex schema in items/additionalProperties/allOf/oneOf/anyOf
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant