Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jaxrs-spec] Improve support for sub-resource locators in jaxrs-spec generartors #15053

Closed
wants to merge 6 commits into from

Conversation

shamus13
Copy link
Contributor

Adds a public string constant by the name of PATH to generated api classes / interfaces with the content of the class level Path annotation, so the path can easily be used in sub-resource locators etc. #15052 (comment)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608

@shamus13
Copy link
Contributor Author

shamus13 commented Mar 26, 2023

Implements suggested solution in #15052

@shamus13 shamus13 changed the title Improve support for sub-resource locators in jaxrs-spec generartors [jaxrs-spec] Improve support for sub-resource locators in jaxrs-spec generartors Apr 2, 2023
@shamus13
Copy link
Contributor Author

shamus13 commented Apr 6, 2023

@wing328

@wing328
Copy link
Member

wing328 commented Dec 13, 2023

can you please resolve the merge conflicts when you've time?

@wing328 wing328 modified the milestones: 7.2.0, 7.3.0 Dec 22, 2023
@wing328 wing328 modified the milestones: 7.3.0, 7.4.0 Feb 8, 2024
@wing328 wing328 modified the milestones: 7.4.0, 7.5.0 Mar 11, 2024
@wing328 wing328 modified the milestones: 7.5.0, 7.6.0 Apr 17, 2024
@shamus13 shamus13 closed this by deleting the head repository Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants