Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C][Client] Allow cJSON_IsNull() for a string if it is not mandatory #14332

Merged
merged 1 commit into from
Dec 28, 2022

Conversation

ityuhui
Copy link
Contributor

@ityuhui ityuhui commented Dec 27, 2022

Hi @wing328 @zhemant @michelealbano

This PR is similar to #13884

Sometimes, the value of string data type in the JSON/YAML string is null

e.g.

{
  "kind": "NodeList",
  "apiVersion": "v1",
  "metadata": {
    "continue": ""
  },
  "items": [
    {
      "kind": "Node",
 ...
      "status": {
 ...
        "phase": null  <---- Here !
      }
    }
  ]
}

Currently openapi-generator/c-libcurl doesn't allow this case, so parsing JSON strings into cJSON objects will fail.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@ityuhui
Copy link
Contributor Author

ityuhui commented Dec 27, 2022

# make
Scanning dependencies of target openapi_petstore
[  6%] Building C object CMakeFiles/openapi_petstore.dir/src/list.c.o
[ 13%] Building C object CMakeFiles/openapi_petstore.dir/src/apiKey.c.o
[ 20%] Building C object CMakeFiles/openapi_petstore.dir/src/apiClient.c.o
[ 26%] Building C object CMakeFiles/openapi_petstore.dir/external/cJSON.c.o
[ 33%] Building C object CMakeFiles/openapi_petstore.dir/model/object.c.o
[ 40%] Building C object CMakeFiles/openapi_petstore.dir/model/api_response.c.o
[ 46%] Building C object CMakeFiles/openapi_petstore.dir/model/category.c.o
[ 53%] Building C object CMakeFiles/openapi_petstore.dir/model/order.c.o
[ 60%] Building C object CMakeFiles/openapi_petstore.dir/model/pet.c.o
[ 66%] Building C object CMakeFiles/openapi_petstore.dir/model/tag.c.o
[ 73%] Building C object CMakeFiles/openapi_petstore.dir/model/user.c.o
[ 80%] Building C object CMakeFiles/openapi_petstore.dir/api/PetAPI.c.o
[ 86%] Building C object CMakeFiles/openapi_petstore.dir/api/StoreAPI.c.o
[ 93%] Building C object CMakeFiles/openapi_petstore.dir/api/UserAPI.c.o
[100%] Linking C shared library libopenapi_petstore.so
[100%] Built target openapi_petstore

@wing328
Copy link
Member

wing328 commented Dec 28, 2022

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants