Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8792 [Java] [jaxrs-cxf] "useAbstractionForFiles" config option for jaxrs-cxf #14316

Merged
merged 22 commits into from
Jan 28, 2023

Conversation

DevFlorian
Copy link
Contributor

@DevFlorian DevFlorian commented Dec 22, 2022

This PR adds "useAbstractionForFiles" config option for jaxrs-cxf as requested in #8792

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)

@DevFlorian DevFlorian changed the title #8792 "useAbstractionForFiles" config option for jaxrs-cxf #8792 [Java] [jaxrs-cxf] "useAbstractionForFiles" config option for jaxrs-cxf Dec 22, 2022
@DevFlorian
Copy link
Contributor Author

@wing328, can you estimate when this PR ist going to bei reviewed? I need this feature in my project.

@wing328
Copy link
Member

wing328 commented Jan 27, 2023

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328 wing328 added this to the 6.3.0 milestone Jan 27, 2023
@wing328
Copy link
Member

wing328 commented Jan 28, 2023

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

You can fix that later. Merging the PR for the time being.

@wing328 wing328 merged commit 6a2d8d2 into OpenAPITools:master Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants