Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][Spring] config option to use Jakarta EE package #14272

Closed
wants to merge 1 commit into from

Conversation

borsch
Copy link
Member

@borsch borsch commented Dec 16, 2022

New configuration option useJakartaEe to control whether to use javax or jakarta package.

Please note that as for now this option is in AbstractJavaCodegen since should be applied to all java generators, but only Spring templates are updated to use it. I did this 1) to reduce scope of changes 2) so that reviewers can confirm whether this approach is fine

Should resolve #14143

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@borsch borsch closed this Dec 21, 2022
@fostiguy
Copy link

fostiguy commented Dec 22, 2022

@borsch Do we know why this PR was closed without merging ? I think many people are waiting to have this new option useJakartaEe available for Java based API code generation (client).

@borsch
Copy link
Member Author

borsch commented Dec 22, 2022

@fostiguy this one seems to be incorrect as this option should depends on library & version that is used. I've created new PR
#14310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ] Support SpringBoot 3.0 GA for Java-based API code generation
2 participants