Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spring] Fix Pascal case for java enum #14104

Conversation

JohnnyMarnell
Copy link
Contributor

Fixes kebab-case or even single uncapitalized foo as schema name for OAS enum yielding compiler errors in Spring java generated EnumConverterConfiguration.java. E.g., both of these generate invalid java file:

components:
  schemas:    
    # currently broken:
    fruit:
      type: string
      enum:
        - ORANGE
        - APPLE
    fruit-type:
      type: string
      enum:
        - ORANGE
        - APPLE

    # this works
    FruitType:
      type: string
      enum:
        - ORANGE
        - APPLE

Spring Technical Committee: @cachescrubber @welshm @MelleD @atextor @manedev79 @javisst @borsch @banlevente @Zomzog

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@welshm
Copy link
Contributor

welshm commented Nov 23, 2022

You'll need to regenerate the samples, but I think the change makes sense

@JohnnyMarnell
Copy link
Contributor Author

Thanks for the review! @welshm I'd run the commands (re-running now just in case), I don't think any new changes are generated, since the classname and name end up the same for the given OAS samples

@welshm
Copy link
Contributor

welshm commented Nov 24, 2022

Thanks for the review! @welshm I'd run the commands (re-running now just in case), I don't think any new changes are generated, since the classname and name end up the same for the given OAS samples

We should probably add a new sample then that highlights the problem, and ideally a unit test that validates the names are as expected.

You can find some examples, but if you need a hand let me know.

@borsch
Copy link
Member

borsch commented Jan 5, 2023

this is already fixed as part of different issue #14356

@wing328 wing328 closed this Jan 5, 2023
@wing328
Copy link
Member

wing328 commented Jan 5, 2023

@JohnnyMarnell can you please pull the latest master to give it another try? thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants