-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Go] File Download Fix Return Type #14046
Conversation
@icubbon thanks for the fix. Let's give it a try. |
} | ||
_, err = f.Seek(0, io.SeekStart) | ||
return | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some indentions in this files and others are using 4-space instead of tabs. I'll file another PR to update that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UPDATE: filed #14189
typeMapping.put("binary", "*os.File"); | ||
typeMapping.put("File", "os.File"); | ||
typeMapping.put("file", "os.File"); | ||
typeMapping.put("binary", "os.File"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@icubbon shall we keep the mapping (pointer to os.File) and fix the code to properly return a pointer to os.File instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @DouglasDwyer (the author of #12685)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid we need to revert this change and instead fix the endpoint to properly return a *os.File
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can take a stab at fixing the mapping to be a *os.File
. It makes sense to have it be an *os.File
as with the newer version of the generator, complex items are now pointers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addresses #11965
The Go
client.decode
expected a**os.File
but the return type is actually a*os.File
.This is almost a copy/pasta of #12685 but that PR has been sitting idle for 5 months without passing all of the checks to be merged in.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(6.3.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks)@antihax @grokify @kemokemo @jirikuncar @ph4r5h4d @wing328