-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Gradle build cache when using absolute path references #13671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghale
reviewed
Oct 11, 2022
modules/openapi-generator-gradle-plugin/src/test/kotlin/GenerateTaskFromCacheTest.kt
Outdated
Show resolved
Hide resolved
modules/openapi-generator-gradle-plugin/src/test/kotlin/GenerateTaskFromCacheTest.kt
Show resolved
Hide resolved
...gradle-plugin/src/main/kotlin/org/openapitools/generator/gradle/plugin/tasks/GenerateTask.kt
Show resolved
Hide resolved
(cherry picked from commit 46c96daf3b020ab02e13113166046d2383c04990)
(cherry picked from commit 5d09d914ba7224b82dd7a3bd20beaf2b6fd3eb94)
(cherry picked from commit 8d9e0dbb9d865ad3e61b60692b3ef6ca85b70b75)
(cherry picked from commit ba1d554c375068974d1799d6be6731ca1d59a783)
(cherry picked from commit 18da6161ba2b406876c516a3059850d9a0bc9ca0)
(cherry picked from commit 4670db92686c02d5dd2b69976488c33defd3a464)
(cherry picked from commit 9150b4a5596b229a4404a92cfedbb795c6bb5b0d)
I'm not sure why CI failed, but it seems unrelated to my changes. |
@wing328 would you be able to look at this? Thank you! |
Restarted the job and all tests passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR marks several file/directory task input properties of the
GenerateTask
as either@InputFile
or@InputDirectory
and@PathSensitive(PathSensitivity.RELATIVE)
.This enables the following:
GenerateTask
will not be consideredUP-TO-DATE
when the contents of one of these files or directories changesGenerateTask
will reuse outputs from the build cache when using absolute file path property values and when running from a different directoryfixes #10214
fixes #11808
fixes #13663
Gradle Build Scan: https://scans.gradle.com/s/dp2plkit3wcxo
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(6.1.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks)If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.