Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix staticcheck ST1005 errors in generated Go client #13633

Merged
merged 3 commits into from
Oct 18, 2022

Conversation

maelick
Copy link
Contributor

@maelick maelick commented Oct 7, 2022

Fixes #13632 by updating the mustache templates that did not follow ST1005.
Verification can be done by rerunning client generation and staticcheck.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Tagging Go technical committee: @antihax @grokify @kemokemo @jirikuncar @ph4r5h4d

@wing328
Copy link
Member

wing328 commented Oct 7, 2022

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328
Copy link
Member

wing328 commented Oct 7, 2022

CI failed: https://app.circleci.com/pipelines/github/OpenAPITools/openapi-generator/19997/workflows/49162131-d99f-4575-8c15-776f0f253eda/jobs/51187

I think you may need to update the tests as well, which may compare the error messages.

@maelick
Copy link
Contributor Author

maelick commented Oct 7, 2022

Fixed

@wing328 wing328 added this to the 6.2.1 milestone Oct 18, 2022
@wing328 wing328 merged commit 41255c1 into OpenAPITools:master Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][go] ST1005 when running staticcheck on generated client code
2 participants