Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some null and length checks to titlecase function #13495

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

cguckes
Copy link
Contributor

@cguckes cguckes commented Sep 22, 2022

Added some null and length checks to titlecase function. It crashes in some cases otherwise

to fix #12738

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)

@wing328
Copy link
Member

wing328 commented Oct 19, 2022

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328
Copy link
Member

wing328 commented Oct 19, 2022

FYI @OpenAPITools/generator-core-team

@wing328 wing328 changed the title fix issue https://github.com/OpenAPITools/openapi-generator/issues/12738 Added some null and length checks to titlecase function Oct 19, 2022
@wing328
Copy link
Member

wing328 commented Oct 19, 2022

Thanks for the fix, which looks good to me.

@wing328 wing328 merged commit a3fbb82 into OpenAPITools:master Oct 19, 2022
@wing328 wing328 added this to the 6.2.1 milestone Oct 19, 2022
@cguckes
Copy link
Contributor Author

cguckes commented Oct 20, 2022

No problem, thanks for including it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Description Failure with no descriptive error
2 participants