Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the null pointer exception when generating examples for schemas in python-experimental #12019

Merged

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Mar 31, 2022

Improves schema example generator for python-experimental
Code forks for:

  • type object
  • any type

Are now handled more clearly.
This fixes this issue: #11518

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@spacether spacether added this to the 6.0.0 milestone Apr 5, 2022
@spacether spacether changed the title Improves schema example generator for python-experimental Fix the null pointer exception when generating examples for schemas in python-experimental Apr 5, 2022
@spacether
Copy link
Contributor Author

I converted the v2sample spec to v3 from here:
https://raw.githubusercontent.com/OAI/OpenAPI-Specification/main/examples/v2.0/yaml/petstore.yaml
And I generated the python-experimental sample and confirmed that the NPE is gone

@spacether spacether merged commit 2e19371 into OpenAPITools:master Apr 7, 2022
@spacether spacether deleted the feat_improves_python_example_gen branch April 7, 2022 18:17
cachescrubber pushed a commit to cachescrubber/openapi-generator that referenced this pull request Apr 9, 2022
…n python-experimental (OpenAPITools#12019)

* Improves example generator for python-experimental

* Fixes quotes around date example

* Improves object schema examplple gen

* Samples regenerated

* Adds back in AnyType + oneOf discriminator handling

* Reverts version file

* Returns early in example gen for array composed schemas

* Adds toExampleValue method to python-exp

* Improves pattern regex sample generation in python-experimental

* Fixes comment typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [python-experimental] Type null not handled properly in toExampleValue
1 participant