Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php-slim4] Add minimal GitHub Action config #11874

Merged
merged 2 commits into from
Mar 15, 2022

Conversation

ybelenko
Copy link
Contributor

I used that example as reference.
The most interesting part is that I've checked it with a fresh repo, output:
First run without coding style check
Second run, coding style check on

I think that failed CI(links above) is absolutely normal regarding this PR, since coding style fix should be added in next PRs. The purpose of this change is to generate CI config which launches GitHub runners without errors(correct syntax).
Relative issue #11858

cc @jebentier, @dkarlovi, @mandrean, @jfastnacht, @ackintosh, @renepardon

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Mar 15, 2022

@ybelenko thanks for the PR.

FYI. I did something similar for the Java client with #11633 before but we didn't check the code style.

@wing328 wing328 merged commit a44c7e0 into OpenAPITools:master Mar 15, 2022
@ybelenko ybelenko deleted the 11858_php_slim4_github_actions branch March 15, 2022 21:09
@wing328 wing328 added this to the 6.0.0 milestone Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants