Update (broken) Vagrant configuration. #1156
Conversation
|
@mknoszlig thanks for the PR. I'll try to find some time tomorrow to test it and hopefully merge it over the weekend. |
|
Tested locally in my Mac. I was able to repeat the issue and confirmed the fix. |
|
@mknoszlig thanks for the PR, which has been merged into master. Quick question if you don't mind - do I need to run |
|
@wing328 Glad to help! re your question: according to the docs, the box should be added automatically (https://www.vagrantup.com/intro/getting-started/boxes.html#using-a-box) when running |
|
@mknoszlig I didn't get any error as it's using the default image. My guess is that it's due to Vagrant setup/installation issue in my machine. |
|
@mknoszlig thanks again for the fix, which has been included in the v3.3.1 release: https://twitter.com/oas_generator/status/1052020299821080577 |
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master(3.3.x),4.0.x. Default:master.Description of the PR
Updated the included Vagrantfile to install a current ubuntu version. Also updated the referred apt repo and keys to ones that are available. With these changes i was able to create a build following the Instructions in the readme (1.6 Docker -> in Vagrant). Hope this will save somebody else some time.
Cheers.