Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated options in Java client generator #11456

Merged
merged 1 commit into from
Jan 30, 2022

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Jan 30, 2022

Remove options that have been marked as deprecated: useRxJava, playVersion

useRxJava2, useRxJava3 have been marked as deprecated and will be removed in 6.x version (default to RxJava3 after that)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)

@wing328 wing328 marked this pull request as ready for review January 30, 2022 07:50
@wing328 wing328 added this to the 5.4.0 milestone Jan 30, 2022
@wing328 wing328 changed the title Remove deprecated options in java client generator Remove deprecated options in Java client generator Jan 30, 2022
@wing328 wing328 merged commit 3ed6343 into master Jan 30, 2022
@wing328 wing328 deleted the java-option-deprecated branch January 30, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant