[csharp-netcore] Enum parameter serialization to use EnumMember value when provided. #11448
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR relates to #11447
Change method
ParameterToString
(ClientUtils) to check if obj is Enum and has a EnumMember prop. If so use that value over the existing logic ofobj.ToString()
This fixes an issue whereby the enum value does not match the value in the openApi schema.
This PR also modifies the location of the yaml location for csharp-netcore/OpenAPIClient-net5.0, to a cloned copy of the java petstore API with changes to trigger the scenario described here. This was done to avoid disturbing clients (java) unrelated to this change.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(5.3.0),6.0.x
@mandrean (2017/08) @frankyjuang (2019/09) @shibayan (2020/02) @Blackclaws (2021/03) @lucamazzanti (2021/05)