-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[typescript-axios] Add stringEnums option #11368
[typescript-axios] Add stringEnums option #11368
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
modules/openapi-generator/src/main/resources/typescript-axios/modelEnum.mustache
Outdated
Show resolved
Hide resolved
...generator/src/main/java/org/openapitools/codegen/languages/TypeScriptAxiosClientCodegen.java
Outdated
Show resolved
Hide resolved
eeeec38
to
b67e5ac
Compare
@ty-v1 can you update the samples please? you need to add |
Sorry, I could not work on it because I bought a new PC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
57ae756
to
786d76c
Compare
…le is not used in modelStringEnum template.
modules/openapi-generator/src/main/resources/typescript-axios/modelObjectEnum.mustache
Show resolved
Hide resolved
Would be great to have this for typescript-fetch as well @ty-v1 |
This PR adds
stringEnums
option to typescript-axios generator.Closes #10943
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(5.3.0),6.0.x
@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)