[kotlin-spring] Move Jackson annotation from field to getter #10825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Please follow step 3 in the PR checklist to update the samples so that the CI can verify the change. cc @jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03) |
|
@wing328 Thanks for the reminder. Step 3, done. |
|
I don't have much experience with jackson, but I think we already merge something similar to kotlin client. |
|
Is there a reason this is not merged ? quite simple solution to strange api spec (not invalid). |
|
@juherr could you please fix the conflicts? Thanks |
|
Hi @juherr, thanks for this fix. Would it be possible to get it merged? |
In some case, Jackson will duplicate entries when the annotation is on field See FasterXML/jackson-databind#1609
juherr
force-pushed
the
bugfix/kotlin-spring-jackson
branch
from
4d1fa15 to
b42b38c
Compare
|
@volsusdev PR rebased |
4brunu
approved these changes
Jan 2, 2023
|
Awesome, thank you guys. Looking forward for the next release including this fix 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, Jackson will duplicate entries when the annotation is on the field.
The behavior is expected, see FasterXML/jackson-databind#1609
Also, a similar issue exists on the java generator: #5705
Ping @jimschubert