Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dart] jaguar remove in 6.x #10534

Merged
merged 2 commits into from
Oct 8, 2021
Merged

Conversation

agilob
Copy link
Contributor

@agilob agilob commented Oct 5, 2021

Marked as deprecated now and for removal in 6

Happy to move it to 7.x if you think that's too early.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@agilob agilob requested a review from jimschubert as a code owner October 5, 2021 17:51
@agilob
Copy link
Contributor Author

agilob commented Oct 5, 2021

@agilob agilob changed the title Dart-jaguar: remove Client Dart: remove Oct 5, 2021
@agilob agilob changed the title Client Dart: remove Client: Dart remove Oct 5, 2021
@agilob agilob changed the title Client: Dart remove Client: Dart jaguar remove Oct 5, 2021
@agilob agilob changed the title Client: Dart jaguar remove [Dart] jaguar remove Oct 6, 2021
@wing328
Copy link
Member

wing328 commented Oct 6, 2021

I sync'd master to 6.0.x a few hours ago. Can you please rebase on the latest 6.0.x to resolve the merge conflicts?

@agilob
Copy link
Contributor Author

agilob commented Oct 6, 2021

Fixed that conflict in browser editor 👍

@agilob agilob changed the title [Dart] jaguar remove [Dart] jaguar remove in 6.x Oct 7, 2021
@wing328 wing328 modified the milestones: 5.3.0, 6.0.0 Oct 8, 2021
@wing328 wing328 merged commit 5b1b74e into OpenAPITools:6.0.x Oct 8, 2021
@agilob agilob deleted the dart-jaguar-remove branch October 8, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants