Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(drone): fix duplicate pipeline names #10437

Merged

Conversation

PiDelport
Copy link
Contributor

@PiDelport PiDelport commented Sep 21, 2021

Drone requires unique pipeline names, which PR #10423 (5c45465) missed.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Drone requires unique pipeline names, which PR OpenAPITools#10423 (5c45465) missed.
@PiDelport
Copy link
Contributor Author

@wing328: The pipelines run correctly and in isolation now, but they still seem to run sequentially: is the concurrency being limited at the Drone Runner level?

@wing328
Copy link
Member

wing328 commented Sep 22, 2021

is the concurrency being limited at the Drone Runner level?

It could be. No expert in Drone.io CI. Like other open-source projects, we're using their free plan.

@wing328 wing328 merged commit 30a37b3 into OpenAPITools:master Sep 22, 2021
@PiDelport
Copy link
Contributor Author

Coolness, all happy now. Parallelism aside, this change also means the different languages' tests now run fully isolated from each other, which wasn't the case before, so that's probably worth keeping the change for even if the actual concurrency stays limited.

@wing328 wing328 added this to the 5.3.0 milestone Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants