Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Python clients in CircleCI #10354

Merged
merged 13 commits into from
Sep 9, 2021
Merged

Test Python clients in CircleCI #10354

merged 13 commits into from
Sep 9, 2021

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Sep 8, 2021

Move python client tests to CircleCI due to low credits in other CI.

cc @spacether

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10) @Jyhess (2019/01) @arun-nalla (2019/11) @spacether (2019/11)

@wing328 wing328 added this to the 5.3.0 milestone Sep 9, 2021
@wing328 wing328 marked this pull request as ready for review September 9, 2021 03:06
@wing328
Copy link
Member Author

wing328 commented Sep 9, 2021

Travis, Appveyor failure not related to this change.

pyenv global 3.6.3
python3 --version

mvn --no-snapshot-updates --quiet verify -Psamples.circleci.node3 -Dorg.slf4j.simpleLogger.defaultLogLevel=error
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the other circleci samples be renamed as node1, node2 etc rather than misc?
Or maybe something like node2_javasampleses

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do it in another PR instead. So many things need to be cleanup in the CI 😭

Copy link
Contributor

@spacether spacether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr! This looks good. Do you want me to merge it or do you want to?

@wing328 wing328 merged commit 483a13f into master Sep 9, 2021
@wing328
Copy link
Member Author

wing328 commented Sep 9, 2021

Just merged.

@wing328 wing328 deleted the circleci-python branch September 9, 2021 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants