Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pojo.mustache for property name conversion #10353

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Update pojo.mustache for property name conversion #10353

merged 1 commit into from
Sep 9, 2021

Conversation

klhmeyer
Copy link
Contributor

@klhmeyer klhmeyer commented Sep 8, 2021

For setters the Jackson based property name conversion (e. g. from _-separated to CamelCase) is missing. So I propose this.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

For setters the Jackson based property name conversion  (e. g.  from _-separated to CamelCase) is missing. So I propose this.
@klhmeyer klhmeyer changed the title Update pojo.mustache Update pojo.mustache for property name conversion Sep 8, 2021
@wing328 wing328 added this to the 5.3.0 milestone Sep 9, 2021
@wing328
Copy link
Member

wing328 commented Sep 9, 2021

Looks good to me. Next time please follow the PR checklist to update the samples and copy the Java technical committee for review.

cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01)

@wing328 wing328 merged commit 66f86d8 into OpenAPITools:master Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants