-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows adaptations and installer configuration #10326
Merged
wing328
merged 18 commits into
OpenAPITools:master
from
ahmedyarub:ay/libcurl_windows_installation
Sep 8, 2021
Merged
Windows adaptations and installer configuration #10326
wing328
merged 18 commits into
OpenAPITools:master
from
ahmedyarub:ay/libcurl_windows_installation
Sep 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cast to correct type when applicable to be compilable on C++ compilers Add conditional instllation of configuration files
ahmedyarub
changed the title
Undefine reserved keywords
Windows adaptations and installer configuration
Sep 4, 2021
ityuhui
reviewed
Sep 6, 2021
modules/openapi-generator/src/main/resources/C-libcurl/CMakeLists.txt.mustache
Outdated
Show resolved
Hide resolved
ityuhui
reviewed
Sep 6, 2021
modules/openapi-generator/src/main/resources/C-libcurl/api-header.mustache
Outdated
Show resolved
Hide resolved
…rator into ay/libcurl_windows_installation
Install header files Set correct flags for target link libraries
ityuhui
reviewed
Sep 7, 2021
modules/openapi-generator/src/main/resources/C-libcurl/model-header.mustache
Outdated
Show resolved
Hide resolved
ityuhui
reviewed
Sep 7, 2021
...penapi-generator/src/main/java/org/openapitools/codegen/languages/CLibcurlClientCodegen.java
Show resolved
Hide resolved
ityuhui
reviewed
Sep 7, 2021
modules/openapi-generator/src/main/resources/C-libcurl/CMakeLists.txt.mustache
Outdated
Show resolved
Hide resolved
ityuhui
reviewed
Sep 7, 2021
This reverts commit 0e25659.
ityuhui
reviewed
Sep 7, 2021
ityuhui
reviewed
Sep 7, 2021
modules/openapi-generator/src/main/resources/C-libcurl/CMakeLists.txt.mustache
Outdated
Show resolved
Hide resolved
ityuhui
reviewed
Sep 7, 2021
modules/openapi-generator/src/main/resources/C-libcurl/CMakeLists.txt.mustache
Outdated
Show resolved
Hide resolved
ityuhui
approved these changes
Sep 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice code !
It's good to me. Thank you !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zhemant @ityuhui @michelealbano
Cast to correct type when applicable to be compilable on C++ compilers
Add conditional installation of configuration files
1- Adaptations for Windows compilation
2- Installer with CMake configuration
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(5.3.0),6.0.x