Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows adaptations and installer configuration #10326

Merged

Conversation

ahmedyarub
Copy link
Contributor

@zhemant @ityuhui @michelealbano

Cast to correct type when applicable to be compilable on C++ compilers
Add conditional installation of configuration files

1- Adaptations for Windows compilation
2- Installer with CMake configuration

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Cast to correct type when applicable to be compilable on C++ compilers
Add conditional instllation of configuration files
@ahmedyarub ahmedyarub changed the title Undefine reserved keywords Windows adaptations and installer configuration Sep 4, 2021
Ahmed Yarub Hani Al Nuaimi added 2 commits September 7, 2021 04:16
Ahmed Yarub Hani Al Nuaimi added 2 commits September 7, 2021 04:43
Copy link
Contributor

@ityuhui ityuhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice code !
It's good to me. Thank you !

@wing328 wing328 added this to the 5.3.0 milestone Sep 8, 2021
@wing328 wing328 merged commit 86ead27 into OpenAPITools:master Sep 8, 2021
@ahmedyarub ahmedyarub deleted the ay/libcurl_windows_installation branch September 8, 2021 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants