-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dart2 template linting #10263
Dart2 template linting #10263
Conversation
Bumps [jimschubert/query-tag-action](https://github.com/jimschubert/query-tag-action) from 1 to 2. - [Release notes](https://github.com/jimschubert/query-tag-action/releases) - [Commits](jimschubert/query-tag-action@v1...v2) Signed-off-by: dependabot[bot] <[email protected]>
…ubert/query-tag-action-2 Bump jimschubert/query-tag-action from 1 to 2
Anyone wants to take a look? |
At last, green! 🤟 |
Code is updated again with |
modules/openapi-generator/src/main/resources/dart2/api_client.mustache
Outdated
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/dart2/api_helper.mustache
Outdated
Show resolved
Hide resolved
@agilob updated the code per your notes, ball's at your end. Thanks! |
@agilob you think it's possible to merge this pr this week? |
@wing328 can we get this in pls? |
@wing328 maybe start the week with a positive merge vibes? :) |
I would like this merged as it will conflict with my dart2 NNBD branch |
Any comments from @kuhnroyal? |
Just merged. Sorry for the delay. |
There have been many changes lately for the Dart linter, particularly the
pedantic
linting has been phased out in favor offlutter_lints
. For upgrade details: https://github.com/dart-lang/lints#migrating-from-packagepedanticAnyway, when I regenerated the source code using the current Dart template and using the linting rules that comes with
flutter_lints
, I got many errors. In addition, I personally use a stricter linter rules and so I also added few ignore to silence the linter in such cases.In addition, there's no more need for implicit casting in the resulting source code and the
analysis_options.yaml
can practically be removed now.All in all, the generated code is much better now and will run in both
pedantic
and the newflutter_lints
.PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(5.3.0),6.0.x
@jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m @wing328 @jaumard @josh-burton @amondnet @sbu-WBT @kuhnroyal @agilob @ahmednfwela