Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dart2 template linting #10263

Merged
merged 57 commits into from
Sep 13, 2021
Merged

Dart2 template linting #10263

merged 57 commits into from
Sep 13, 2021

Conversation

noordawod
Copy link
Contributor

@noordawod noordawod commented Aug 25, 2021

There have been many changes lately for the Dart linter, particularly the pedantic linting has been phased out in favor of flutter_lints. For upgrade details: https://github.com/dart-lang/lints#migrating-from-packagepedantic

Anyway, when I regenerated the source code using the current Dart template and using the linting rules that comes with flutter_lints, I got many errors. In addition, I personally use a stricter linter rules and so I also added few ignore to silence the linter in such cases.

In addition, there's no more need for implicit casting in the resulting source code and the analysis_options.yaml can practically be removed now.

All in all, the generated code is much better now and will run in both pedantic and the new flutter_lints.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m @wing328 @jaumard @josh-burton @amondnet @sbu-WBT @kuhnroyal @agilob @ahmednfwela

dependabot bot and others added 27 commits May 12, 2021 06:10
…ubert/query-tag-action-2

Bump jimschubert/query-tag-action from 1 to 2
@noordawod
Copy link
Contributor Author

Anyone wants to take a look?
@jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m @wing328

@noordawod
Copy link
Contributor Author

At last, green! 🤟

@noordawod
Copy link
Contributor Author

Code is updated again with master, would be nice to have it reviewed and approved?
@kuhnroyal @wing328 @ahmednfwela

@noordawod
Copy link
Contributor Author

@agilob updated the code per your notes, ball's at your end. Thanks!

@noordawod
Copy link
Contributor Author

@agilob you think it's possible to merge this pr this week?

@agilob
Copy link
Contributor

agilob commented Sep 6, 2021

@wing328 can we get this in pls?

@noordawod
Copy link
Contributor Author

@wing328 maybe start the week with a positive merge vibes? :)

@agilob
Copy link
Contributor

agilob commented Sep 12, 2021

I would like this merged as it will conflict with my dart2 NNBD branch

@agilob
Copy link
Contributor

agilob commented Sep 12, 2021

Any comments from @kuhnroyal?

@wing328 wing328 merged commit 495f6eb into OpenAPITools:master Sep 13, 2021
@wing328
Copy link
Member

wing328 commented Sep 13, 2021

Just merged. Sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants