-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Libcurl CMake adaptations #10249
Merged
Merged
Libcurl CMake adaptations #10249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove default build type Add OpenSSL using imported targets PreTarget and PostTarget scripts Do not build as shared by default Fix typos
ityuhui
reviewed
Aug 25, 2021
modules/openapi-generator/src/main/resources/C-libcurl/CMakeLists.txt.mustache
Show resolved
Hide resolved
ityuhui
reviewed
Aug 26, 2021
modules/openapi-generator/src/main/resources/C-libcurl/CMakeLists.txt.mustache
Outdated
Show resolved
Hide resolved
Correctly add target link libraries
ityuhui
reviewed
Aug 27, 2021
modules/openapi-generator/src/main/resources/C-libcurl/CMakeLists.txt.mustache
Outdated
Show resolved
Hide resolved
ityuhui
reviewed
Aug 27, 2021
modules/openapi-generator/src/main/resources/C-libcurl/CMakeLists.txt.mustache
Show resolved
Hide resolved
ityuhui
approved these changes
Aug 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change is OK to me. @wing328
Thank you @ahmedyarub !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zhemant @ityuhui @michelealbano
Remove default build type and library shared flag
Add OpenSSL using imported targets on supported CMake versions
PreTarget and PostTarget scripts where the former one is used to add new source files and run additional find_package() commands, and the latter can be used to add optional components such as whether to include building examples and also to customize the installation command.
Related PR which I'm going to close in favor of this later: kubernetes-client/c#75
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(5.3.0),6.0.x