-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add map property in url params #10154
Conversation
Damn, I did this yesterday but didn't open a PR cause of the 5.2.1 release :) |
Can you copy the tests from https://github.com/kuhnroyal/openapi-generator/tree/dart-dio/query-maps |
It's hard to distil your change and find what's dart-test change you want added and what is generated, but I think I found what was missing |
Looks about right, just needs some formatting. |
Is that test supposed to be failing? |
I think this is just a formatting failure. Can you run |
428bfdf
to
35e0180
Compare
I removed the commits adding the dart tests. They are failing locally and I feel they are out of scope for this PR, as I only wanted to add spec changes without anything language specific. I'll let you add the tests as you want, I think I missed some changes from your PR... |
Adding map property in url params to test generation of this specific case in generators as requested in #10116 (comment)
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.3.x
,6.0.x
@wing328