-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]Java] Fix a race condition in RetryingOAuth.mustache #10087
[BUG]Java] Fix a race condition in RetryingOAuth.mustache #10087
Conversation
.../client/petstore/java/feign-no-nullable/src/main/java/org/openapitools/client/ApiClient.java
Show resolved
Hide resolved
} | ||
} catch (OAuthSystemException | OAuthProblemException e) { | ||
throw new IOException(e); | ||
} | ||
} | ||
|
||
return false; | ||
return getAccessToken() == null || !getAccessToken().equals(requestAccessToken); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously: only ever returned true
if this thread got a new token.
Now: returns true
if any thread got a new token.
} | ||
|
||
@Test | ||
public void testTwoConcurrentRequestsUnauthorized() throws Exception { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test fails with the previous version of RetryingOAuth.mustache
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
If there were multiple concurrent requests at a time at which the OAuth token had expired, only a single request would be retried. The other requests would fail because of the expired token, but not be retried and so the failures would be propagated to the caller.
52c52ad
to
44b414b
Compare
Thanks for pointing that out @wing328 -- I have now (I think) corrected the author on the commit so it matches my Github account. |
cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01) |
@Dretch thanks for the fix, which looks good to me. |
If there were multiple concurrent requests at a time at which the OAuth token had expired, only a single request would be retried. The other requests would fail because of the expired token, but not be retried and so the failures would be propagated to the caller.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.3.x
,6.0.x