Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C][Client] Free the variable with the data type "byteArray" same as "string" #10067

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

ityuhui
Copy link
Contributor

@ityuhui ityuhui commented Jul 31, 2021

This is a follow-up of PR #10034.

This PR will free the variable with the data type "byteArray" same as "string" in the function *_free() .

Hi @zhemant @wing328 @michelealbano

Could you please review this PR ? Thanks.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the master: master, 5.3.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Aug 3, 2021

LGTM but I didn't test it locally.

@wing328 wing328 merged commit c21e6de into OpenAPITools:master Aug 3, 2021
@ityuhui ityuhui deleted the yh-bytearray-2nd branch August 4, 2021 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants